"""Regression coverage for issue #2351 CLI session list separation.""" from pathlib import Path ROOT = Path(__file__).resolve().parents[1] SESSIONS_JS = ROOT / "static" / "sessions.js" STYLE_CSS = ROOT / "static" / "style.css" def test_sidebar_has_separate_webui_and_cli_session_source_tabs(): src = SESSIONS_JS.read_text(encoding="utf-8") assert "let _sessionSourceFilter = 'webui'" in src assert "hermes-session-source-filter" in src assert "session-source-tabs" in src assert "t('sessions_source_webui', n)" in src assert "t('sessions_source_cli', n)" in src assert "_sessionSourceFilter==='cli'" in src def test_session_source_labels_are_locale_keys_with_number_placeholder(): """Issue #7580: source tab labels must come from t() with {0}-interpolated counts, not hardcoded English template literals.""" i18n = (ROOT / "static" / "i18n.js").read_text(encoding="utf-8") assert "sessions_source_webui: 'WebUI sessions ({0})'" in i18n # en bundle assert "sessions_source_cli: 'CLI sessions ({0})'" in i18n # en bundle assert "sessions_source_webui: 'Сеансы WebUI ({0})'" in i18n # ru bundle assert "sessions_source_cli: 'Сеансы CLI ({0})'" in i18n # ru bundle sessions_src = SESSIONS_JS.read_text(encoding="utf-8") assert "t('sessions_source_cli', n)" in sessions_src assert "t('sessions_source_webui', n)" in sessions_src # The template-literal fallback must be gone: labels now come from the locale. assert "`CLI sessions (${n})`" not in sessions_src assert "`WebUI sessions (${n})`" not in sessions_src def test_cli_filter_keeps_cli_rows_out_of_default_webui_list(): src = SESSIONS_JS.read_text(encoding="utf-8") assert "function _partitionSidebarSessionRows(allMatched, activeSidForSidebar)" in src assert "cliSessionCount" in src assert "const showCliOnly=_sessionSourceFilter==='cli';" in src assert "const webuiProfileFiltered=[];" in src assert "const cliProfileFiltered=[];" in src assert "const webuiSessionsRaw=[];" in src assert "const cliSessionsRaw=[];" in src assert "profileFiltered: showCliOnly ? cliProfileFiltered : webuiProfileFiltered," in src assert "sessionsRaw: showCliOnly ? cliSessionsRaw : webuiSessionsRaw," in src def test_session_source_tabs_have_dedicated_sidebar_styles(): css = STYLE_CSS.read_text(encoding="utf-8") assert ".session-source-tabs" in css assert ".session-source-tab.active" in css assert ".session-empty-note" in css def test_webui_state_db_mirror_does_not_become_cli_sidebar_row(): from api.routes import _merge_cli_sidebar_metadata merged = _merge_cli_sidebar_metadata( {"session_id": "webui-tip", "title": "Long WebUI session", "source_tag": "webui"}, { "session_id": "webui-tip", "source_tag": "webui", "session_source": "webui", "message_count": 1740, }, ) assert merged["is_cli_session"] is False assert merged["source_tag"] == "webui" assert merged["session_source"] == "webui" assert merged["message_count"] == 1740 def test_real_cli_state_db_mirror_stays_cli_sidebar_row(): from api.routes import _merge_cli_sidebar_metadata merged = _merge_cli_sidebar_metadata( {"session_id": "cli-tip", "title": "CLI session", "source_tag": "cli"}, { "session_id": "cli-tip", "source_tag": "cli", "session_source": "cli", "message_count": 12, }, ) assert merged["is_cli_session"] is True assert merged["session_source"] == "cli" def test_stale_webui_sidebar_cli_flag_is_cleared_before_frontend_response(): from api.routes import _normalize_sidebar_source_flags normalized = _normalize_sidebar_source_flags( { "session_id": "webui-tip", "title": "Long WebUI session", "source_tag": "webui", "session_source": "webui", "is_cli_session": True, "message_count": 1740, } ) assert normalized["is_cli_session"] is False assert normalized["source_tag"] == "webui" assert normalized["session_source"] == "webui" def test_webui_source_overrides_stale_cli_flag_even_with_default_title(): from api.agent_sessions import is_cli_session_row from api.routes import _normalize_sidebar_source_flags stale_webui = { "session_id": "webui-default-title", "title": "CLI Session", "source_tag": "webui", "session_source": "webui", "source_label": "WebUI", "is_cli_session": True, "message_count": 23, } assert is_cli_session_row(stale_webui) is False assert _normalize_sidebar_source_flags(stale_webui)["is_cli_session"] is False def test_webui_state_db_source_overrides_stale_cli_detail_payload(): from api.routes import _reconcile_session_detail_source_flags detail_payload = { "session_id": "webui-tip", "title": "Long WebUI session", "source_tag": "cli", "raw_source": "cli", "session_source": "cli", "source_label": "CLI", "is_cli_session": True, "read_only": True, "message_count": 24, } state_db_row = { "session_id": "webui-tip", "source_tag": "webui", "raw_source": "webui", "session_source": "webui", "source_label": "WebUI", "message_count": 26, } reconciled = _reconcile_session_detail_source_flags(detail_payload, state_db_row) assert reconciled["is_cli_session"] is False assert reconciled["read_only"] is False assert reconciled["source_tag"] == "webui" assert reconciled["raw_source"] == "webui" assert reconciled["session_source"] == "webui" assert reconciled["source_label"] == "WebUI" assert reconciled["message_count"] == 26 def test_real_cli_source_survives_detail_source_reconcile(): from api.routes import _reconcile_session_detail_source_flags detail_payload = { "session_id": "cli-tip", "source_tag": "cli", "raw_source": "cli", "session_source": "cli", "source_label": "CLI", "is_cli_session": True, "read_only": True, } state_db_row = { "session_id": "cli-tip", "source_tag": "cli", "raw_source": "cli", "session_source": "cli", "source_label": "CLI", } reconciled = _reconcile_session_detail_source_flags(detail_payload, state_db_row) assert reconciled["is_cli_session"] is True assert reconciled["read_only"] is True assert reconciled["source_tag"] == "cli" def test_real_cli_sidebar_cli_flag_is_preserved_before_frontend_response(): from api.routes import _normalize_sidebar_source_flags normalized = _normalize_sidebar_source_flags( { "session_id": "cli-tip", "title": "CLI session", "source_tag": "cli", "session_source": "cli", "is_cli_session": True, "message_count": 12, } ) assert normalized["is_cli_session"] is True def test_tui_state_db_rows_are_cli_sidebar_rows(): """Hermes TUI state.db rows belong in the CLI/agent sidebar bucket. TUI sessions are projected from state.db with raw/source_tag='tui'. If they stay session_source='other' and is_cli_session=false, the two-tab sidebar partition can make active TUI continuations disappear from both the WebUI and CLI views. """ from api.agent_sessions import is_cli_session_row, normalize_agent_session_source from api.routes import _normalize_sidebar_source_flags normalized_source = normalize_agent_session_source("tui") assert normalized_source["session_source"] == "cli" assert normalized_source["source_label"] == "TUI" tui_row = { "session_id": "tui-tip", "title": "Podcast work #17", "source_tag": "tui", "raw_source": "tui", "session_source": "other", "source_label": "Tui", "message_count": 281, } assert is_cli_session_row(tui_row) is True assert _normalize_sidebar_source_flags(tui_row)["is_cli_session"] is True def test_tui_continuation_projection_uses_latest_tip_title(): """TUI continuation rows should surface under the latest segment title.""" from api.agent_sessions import _project_agent_session_rows rows = [ { "id": "tui_parent", "source": "tui", "title": "Podcast work #6", "started_at": 100.0, "last_activity": 150.0, "message_count": 10, "actual_message_count": 10, "actual_user_message_count": 5, "parent_session_id": None, "ended_at": 199.0, "end_reason": "cli_close", }, { "id": "tui_tip", "source": "tui", "title": "Podcast work #17", "started_at": 200.0, "last_activity": 250.0, "message_count": 8, "actual_message_count": 8, "actual_user_message_count": 4, "parent_session_id": "tui_parent", "ended_at": None, "end_reason": None, }, ] projected = _project_agent_session_rows(rows) assert len(projected) == 1 assert projected[0]["id"] == "tui_tip" assert projected[0]["title"] == "Podcast work #17" assert projected[0]["_lineage_root_id"] == "tui_parent" assert projected[0]["_lineage_tip_id"] == "tui_tip" def test_external_agent_rows_classify_as_cli_matching_client_render(): """Regression for #5831: external_agent (Claude Code) imports must count as CLI. The client renderer (static/sessions.js: _isCliSession) files an external_agent/claude_code row into the CLI bucket via the is_cli_session fallthrough. The server session-count classifier used to return False for such a row (it carries a real title, so it fell through to the conservative default-title gate), counting it under webui_session_count while the client rendered it under CLI. Result: the WebUI filter showed a non-zero count with an empty list. Server and client must agree — external_agent is CLI. """ from api.agent_sessions import is_cli_session_row claude_code_row = { "session_id": "claude_code_e62d0c1a6e8d55839e298973", "title": "Overview of AI Capabilities", "source_tag": "claude_code", "raw_source": "claude_code", "session_source": "external_agent", "source_label": "Claude Code", "is_cli_session": True, "read_only": True, "message_count": 225, } # The bug: a real-titled external_agent row was classified non-CLI. assert is_cli_session_row(claude_code_row) is True # Hyphenated variant is treated identically. assert is_cli_session_row({**claude_code_row, "session_source": "external-agent"}) is True def test_external_agent_classification_does_not_overreach(): """The external_agent → CLI branch must not reclassify unrelated sources.""" from api.agent_sessions import is_cli_session_row # Genuine WebUI session stays non-CLI (webui bucket). assert is_cli_session_row( {"session_source": "webui", "is_cli_session": False, "title": "My chat"} ) is False # Messaging session stays non-CLI. assert is_cli_session_row( {"session_source": "messaging", "source_tag": "telegram", "is_cli_session": True, "title": "tg"} ) is False # Delegated subagent (#5307) stays non-CLI / view-only. assert is_cli_session_row( {"session_source": "subagent", "is_cli_session": True, "title": "delegated child"} ) is False